Add ability to re-send account creation emails. #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submitting the "invite user" form a second time will now send a new email.
tienne-B
reviewed
Jan 28, 2025
Co-authored-by: Étienne Beaulé <[email protected]>
|
For This might cause some confusion if a user is invited once with some role, but the follow-up email is sent with a different role (as the second role will be ignored). However, I think this is more reasonable than changing the user's role here (this should be done separately if necessary)? |
|
@teymour-aldridge That is a good point! A user can have many groups, and different groups between tournaments, so that new user check is problematic. Have you tried using the I think it'd look something like this: user.membership_set.add(self.cleaned_data['role']) |
tienne-B
reviewed
Feb 9, 2025
| @@ -34,7 +34,8 @@ def get_users(self, email): | |||
| 'username': email.split("@")[0], | |||
| }, | |||
| ) | |||
| user.membership_set.create(group=self.cleaned_data['role']) | |||
| if created: | |||
There was a problem hiding this comment.
With the .add() method call, do we need this check? It could cause problems if re-inviting a user, but with a new group (like CA + Equity or in another tournament)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting the "invite user" form a second time will now send a new email.
Fixes #2582